This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Improvements to magic command argument parsing #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var args = input.Split(null as char[], StringSplitOptions.RemoveEmptyEntries); | ||
| // This regex looks for four types of matches: | ||
| // 1. (\{.*\}) |
Contributor
There was a problem hiding this comment.
Thanks for the detailed explanation of the RE in the comments.
Contributor
Author
There was a problem hiding this comment.
That was as much for myself as for anyone else! Otherwise there's no way that I would be able to reverse-engineer this regex a month from now. 😄
ricardo-espinoza
approved these changes
Jun 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the magic command argument parsing code in the
AbstractMagicbase class by using regular expression matching rather than manual string parsing.Previously, arguments were supported only as
key=value. This had two problems:%configmagic, which supportskey = value(with whitespace around the equals sign).valueas a string containing whitespace. This is desirable, for example, when specifying a job name for an Azure Quantum submission.With these changes, arguments such as
key = valueandkey = "value with whitespace"are supported, where whitespace is optionally allowed on both sides of the equals sign. We also supportkeyand"value only"arguments to magic commands that expect a single-token argument.Parsing behavior for arguments provided as JSON (i.e., when called from Python) is unaffected by these changes, and there are a number of existing tests which validate that code path.