This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Support kernel interrupt for %azure.execute #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranade
approved these changes
Jun 22, 2020
Co-authored-by: Chris Granade <chgranad@microsoft.com>
Base automatically changed from
rmshaffer/azure-mock-tests
to
feature/azure-client
June 22, 2020 23:34
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consumes the latest changes from Microsoft.Jupyter.Core, specifically microsoft/jupyter-core#59 and microsoft/jupyter-core#61, in order to support kernel interrupt for the
%azure.executecommand. For example, this means that if a user clicks the "Interrupt" button in the Jupyter Notebook interface while waiting for a job to finish executing, the cell will immediately return with a message saying that the job has not yet completed. Addresses AB#15594.As part of this, I'm also adding the
CancellationTokenparameter to all of theAzureClientmagic commands, since ideally in the future all of the Azure service calls will respond to kernel interrupt. And I've updated theAbstractMagicbase class to derive from the newCancellableMagicSymbol, such that any of the built-in IQ# magics will be able to easily support cancellation if they choose. (But no changes to the built-in magics are included in this PR.)To do before merging: