This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Register new display encoders when loading packages. #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmshaffer
previously approved these changes
Jun 24, 2020
Contributor
rmshaffer
left a comment
rmshaffer
left a comment
There was a problem hiding this comment.
Looks nice, thanks for doing this! Just a couple of small comments.
src/Kernel/IQSharpEngine.cs
Outdated
| .Select(asm => asm.Assembly.GetName()) | ||
| .ToImmutableHashSet() | ||
| // Except assemblies known at compile-time as well. | ||
| .Add(typeof(StateVectorToHtmlResultEncoder).Assembly.GetName()); |
Contributor
There was a problem hiding this comment.
When #177 is merged, the AzureClient assembly will also have some display encoders in it. Just FYI to whichever one of us merges second.
Contributor
Author
There was a problem hiding this comment.
Good to know, thanks! Given what you said about conda breaking until #177, it probably makes sense for that one to go first and for me to catch up?
Contributor
There was a problem hiding this comment.
Probably yes, that makes sense. Hoping to be able to merge that first thing tomorrow morning.
rmshaffer
previously approved these changes
Jun 24, 2020
rmshaffer
previously approved these changes
Jun 25, 2020
rmshaffer
approved these changes
Jun 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new event handler that loads display encoders from new packages as they are loaded, allowing packages to extend the display encoder mechanism to handle types not known at IQ# compile time.