This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Add ExecutionPathTracer to repo.
#195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theRoughCode
requested review from
anpaz,
cgranade,
ricardo-espinoza and
rmshaffer
cgranade
reviewed
Jul 2, 2020
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
I'll leave it to @rmshaffer as to how this fits into the IQ# codebase itself, but I wanted to give some feedback on the C# style; please let me know if I can expand on anything. Thank you!
rmshaffer
reviewed
Jul 2, 2020
rmshaffer
reviewed
Jul 2, 2020
Contributor
rmshaffer
left a comment
rmshaffer
left a comment
There was a problem hiding this comment.
I'll review more later, but I just wanted to get a few initial comments to you!
theRoughCode
force-pushed
the
raphael/tracer
branch
from
ec5dfa5 to
10cd19d
Compare
6 tasks
theRoughCode
force-pushed
the
raphael/tracer
branch
from
0c1b7ec to
84122ac
Compare
Merged
theRoughCode
commented
Jul 15, 2020
| { | ||
| var measureQubit = metadata.Targets.ElementAt(0); | ||
| var clsReg = this.CreateClassicalRegister(measureQubit); | ||
| // TODO: Change this to using IsMeasurement |
Contributor
Author
There was a problem hiding this comment.
Note: this will be addressed in a separate PR so as not to clutter this one.
theRoughCode
force-pushed
the
raphael/tracer
branch
from
22ca0ea to
434fd3f
Compare
theRoughCode
force-pushed
the
feature/path_visualizer
branch
from
8ec979b to
498917c
Compare
theRoughCode
force-pushed
the
raphael/tracer
branch
from
434fd3f to
ec8a53e
Compare
added 11 commits
July 16, 2020 23:40
theRoughCode
force-pushed
the
raphael/tracer
branch
from
ae9e2e3 to
5096ba3
Compare
rmshaffer
approved these changes
Jul 17, 2020
Contributor
rmshaffer
left a comment
rmshaffer
left a comment
There was a problem hiding this comment.
Looking good to me. Thanks @theRoughCode!
theRoughCode
added a commit
that referenced
this pull request
Jul 25, 2020
* Add ExecutionPathTracer to repo * Add WithExecutionPathTracer extension method to SimulatorBase * Respond to PR feedback * Use GetRuntimeMetadata * Remove ApplyToEach * Add tests * Use Newtonsoft instead of System.Text.Json * Rename ArgStr to DisplayArgs * Clean up code * Fix typo in tsconfig * Fix tests
theRoughCode
pushed a commit
that referenced
this pull request
Jul 31, 2020
* Add path visualizer JS files (#201) * Add JS tests for ExecutionPathVisualizer (#205) * Add test for operations with no qubits (#217) * Add `ExecutionPathTracer` to repo. (#195) * Add ExecutionPathTracer to repo * Add WithExecutionPathTracer extension method to SimulatorBase * Respond to PR feedback * Use GetRuntimeMetadata * Remove ApplyToEach * Add tests * Use Newtonsoft instead of System.Text.Json * Rename ArgStr to DisplayArgs * Clean up code * Fix typo in tsconfig * Fix tests * Add trace magic command (#209) * Add view magic command * Rename ExecutionPathEncoder to DisplayableHtmlEncoder * Add documentation to view command * Rename %view to %trace * Fix JSON parsing * Add TraceMagic test * Add flag for depth * Fix nested test * Empty commit to trigger CI * Empty commit to trigger CI * Wrap DisplayArgs in parentheses (#225) * Change depth flag to --depth * Add parentheses around DisplayArgs if it doesn't have it * Trigger CI rebuild * Fix depth bug and render all ops at or above desired depth (#226) * Bump qsharp-runtime version and add tests for operations as args (#227) * Add tests for operations with operations as arguments * Build 0.12.2007.2301. Co-authored-by: Project Collection Build Service (ms-quantum) <> * Implement `IsMeasurement` flag for execution path operations (#230) * Implement isMeasurement flag for execution path operations * Rename 'controlled' and 'adjoint' to 'isControlled' and 'isAdjoint' * Allow default depth for %trace to be set in %config (#229) * Allow default depth for %trace to be set in %config * Fix config magic description * Add composite operation handling (#219) * Add composite operation handling * Add ForEach tests * Add Canon.qs to Tests.IQSharp.csproj * Build 0.12.2007.2412. * Fix ResetAll tests * Fix tests to allow using Microsoft.Quantum.Canon * Add newline * Build 0.12.2007.3008. * Reformat ExecutionPathTracer stylistically * Fix iqsharp.sln * Empty commit to retrigger CI * Remove dotnet test args * Fix broken build * Fix TraceMagic test * Fix broken build tests Co-authored-by: Project Collection Build Service (ms-quantum) <> * Add syntax highlighting for %trace and %lsopen commands (#240) * Add syntax highlighting for %trace command * Fix ordering and add lsopen
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the first out of 3 components (Simulator, JavaScript renderer, magic command) required to implement #158 .
This PR adds the
ExecutionPathTracerfiles and the extension method to attach to any simulator and trace out the operations performed in a given execution path.This will be merged in to the feature branch (
feature/path_visualizer).Note: This should be merged in after updating the
qsharp-runtimeversion to include this PR.