This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Make GetOptionOrDefault public. #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmshaffer
approved these changes
Jul 30, 2020
Contributor
rmshaffer
left a comment
rmshaffer
left a comment
There was a problem hiding this comment.
Thanks, this should be useful!
4 tasks
cgranade
referenced
this pull request
in qsharp-community/qsharp-integrations
Aug 12, 2020
Add IQ# magic to OpenQasmExporter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
IConfigurationSource.GetOptionOrDefault<T>public, as that allows for separating configuration option handling into different assemblies (see the work at https://github.com/microsoft/QuantumLibraries/tree/cgranade/experimental/diagnostics for an example of where this is useful).