This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Add display hook to pass diagnostics to Python notebooks #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmshaffer
reviewed
Aug 7, 2020
Contributor
rmshaffer
left a comment
rmshaffer
left a comment
There was a problem hiding this comment.
Thanks for doing this! Looks great, will approve once CI is passing.
| return self._execute( | ||
| f'%{magic} {json.dumps(map_tuples(kwargs))}', | ||
| raise_on_stderr=raise_on_stderr, _quiet_=_quiet_, | ||
| **kwargs |
Contributor
There was a problem hiding this comment.
Perhaps **kwargs shouldn't be passed through here, since it's being converted to JSON as an argument to the magic command? I noticed the CI failure and I assume it's related to this.
Contributor
Author
There was a problem hiding this comment.
Good catch, thank you! I must have made that chance accidentally renaming things to be consistent, will revert that line.
rmshaffer
approved these changes
Aug 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new display hook to allow passing diagnostic displays from IQ# all the way through Python notebooks as well as IQ# notebooks, addressing an issue raised by @guenp in offline discussions about microsoft/QuantumLibraries#302.
NB: This PR introduces changes to the API surface of the IQ# client for Python, but these changes are fully localized to private methods.