This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Handle nullability of diagnostic severities. #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjbur
previously approved these changes
Mar 5, 2021
This reverts commit dbf05f3.
anjbur
approved these changes
Mar 5, 2021
ricardo-espinoza
pushed a commit
that referenced
this pull request
Mar 12, 2021
* Handle nullability of diagnostic severities. * Ensure that LSP.Diagnostic.Range is not null. * Revert "Ensure that LSP.Diagnostic.Range is not null." This reverts commit dbf05f3.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method overload to QSharpLogger that allows
MapLevelto accept either diagnostic severities or nullable diagnostic severities. This is required due to changes in the language server protocol client API, as in the new version of that API, diagnostic severities are allowed to be absent (represented bynull). As a result, this change is required by microsoft/qsharp-compiler#886, and in turn by microsoft/qsharp-compiler#885.