Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@cgranade
Copy link
Contributor

@cgranade cgranade commented Mar 2, 2020

This PR adds API documentation for all public APIs in the Jupyter project for IQ#.

@cgranade cgranade requested review from anpaz and tcNickolas March 2, 2020 23:04
tcNickolas
tcNickolas previously approved these changes Mar 6, 2020
Copy link
Contributor

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scanned through the changes, learned something new and left a couple of small comments; looks good!

Co-Authored-By: Mariia Mykhailova <mamykhai@microsoft.com>
@cgranade
Copy link
Contributor Author

cgranade commented Mar 6, 2020

Thanks for the review, @tcNickolas! I've addressed your comment, which as a side effect dismissed your review. If you could please approve again, I'd appreciate it. Thanks!

@cgranade cgranade merged commit cee788b into master Mar 7, 2020
@cgranade cgranade deleted the cgranade/api-docs branch March 7, 2020 00:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants