remove com.sun.jdi.VMDisconnectedException from reasonable places. by andxu · Pull Request #104 · microsoft/java-debug

andxu · 2017-11-14T02:58:01Z

org.eclipse.jdi.internal.connect.PacketSendManagersendPacket at PacketSendManager.java Line 90 org.eclipse.jdi.internal.MirrorImplrequestVM at MirrorImpl.java Line 187 org.eclipse.jdi.internal.MirrorImplrequestVM at MirrorImpl.java Line 268 org.eclipse.jdi.internal.VirtualMachineImplgetIDSizes at VirtualMachineImpl.java Line 984 org.eclipse.jdi.internal.VirtualMachineImplpacketSendManager at VirtualMachineImpl.java Line 343 org.eclipse.jdi.internal.MirrorImplrequestVM at MirrorImpl.java Line 187 org.eclipse.jdi.internal.MirrorImplrequestVM at MirrorImpl.java Line 268 org.eclipse.jdi.internal.VirtualMachineImplgetVersionInfo at VirtualMachineImpl.java Line 1010 org.eclipse.jdi.internal.VirtualMachineImplversion at VirtualMachineImpl.java Line 939 com.microsoft.java.debug.core.adapter.handler.AttachRequestHandlerhandle at AttachRequestHandler.java Line 65 com.microsoft.java.debug.core.adapter.DebugAdapterdispatchRequest at DebugAdapter.java Line 80 com.microsoft.java.debug.core.adapter.ProtocolServerdispatchRequest at ProtocolServer.java Line 66 com.microsoft.java.debug.core.protocol.AbstractProtocolServerprocessData at AbstractProtocolServer.java Line 166 com.microsoft.java.debug.core.protocol.AbstractProtocolServerstart at AbstractProtocolServer.java Line 80 com.microsoft.java.debug.core.adapter.ProtocolServerstart at ProtocolServer.java Line 53 com.microsoft.java.debug.plugin.internal.JavaDebugServer$2run at JavaDebugServer.java Line 136 java.util.concurrent.Executors$RunnableAdaptercall at Executors.java Line 514 java.util.concurrent.FutureTaskrun at FutureTask.java Line 264 java.util.concurrent.ThreadPoolExecutorrunWorker at ThreadPoolExecutor.java Line 1167 java.util.concurrent.ThreadPoolExecutor$Workerrun at ThreadPoolExecutor.java Line 641 java.lang.Threadrun at Thread.java Line 844

…onfigurationDone request.

…en debug session is actually useless after jvm terminates.

akaroml · 2017-11-17T06:08:10Z

...g.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/AttachRequestHandler.java

                    context.sendEvent(Events.OutputEvent.createConsoleOutput(warnMessage));
                }
            }
+        } catch (VMDisconnectedException e) {


This exception seems like a common one for all the handlers. Can we handle them at the framework level?

…happening, since it is normal to have received terminated message during process vscode requests, return an empty response since the debug session is terminated.

testforstephen · 2017-11-21T03:19:35Z

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/Breakpoint.java

+        try {
+            vm.eventRequestManager().deleteEventRequests(requests());
+        } catch (VMDisconnectedException ex) {
+            // ignore since removing breakpoints is meanness when JVM is terminated.


typos. meaningless

# Conflicts: # com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/DebugAdapter.java # com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/ThreadsRequestHandler.java

…ttach

# Conflicts: # com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/DebugAdapter.java # com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/ThreadsRequestHandler.java

akaroml · 2017-11-29T03:26:52Z

...soft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/ProtocolServer.java

@@ -68,16 +70,32 @@ protected void dispatchRequest(Messages.Request request) {
        this.debugAdapter.dispatchRequest(request).whenComplete((response, ex) -> {


Use thenAccept.

akaroml · 2017-11-29T03:27:04Z

...soft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/ProtocolServer.java

+                            "The request dispatcher should not return null response."));
+                }
+            }
+        }).whenComplete((r, e) -> {


Use exceptionally().

akaroml · 2017-11-29T03:27:35Z

...soft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/ProtocolServer.java

-                        ErrorCode.UNKNOWN_FAILURE,
-                        "The request dispatcher should not return null response."));
+                response = new Messages.Response(request.seq, request.command);
+                if (ex != null) {


Put the exception handling logic into the exceptionally() handler.

akaroml · 2017-11-29T03:28:06Z

...soft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/ProtocolServer.java

@@ -68,16 +70,32 @@ protected void dispatchRequest(Messages.Request request) {
        this.debugAdapter.dispatchRequest(request).whenComplete((response, ex) -> {
            if (response != null) {


Don't need to check response for null value when using thenAccept.

# Conflicts: # com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/ProtocolServer.java # com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/ThreadsRequestHandler.java

add logs for attaching errors.

e52d41f

yaohaizh previously approved these changes Nov 14, 2017

View reviewed changes

andxu dismissed yaohaizh’s stale review via 07262b9 November 14, 2017 04:09

andxu added 2 commits November 14, 2017 13:14

In attach scenario, the remote JVM may be already terminated before C…

2424752

…onfigurationDone request.

Avoid to pop up error message to users for vm terminated exception wh…

80c2360

…en debug session is actually useless after jvm terminates.

andxu changed the title ~~add logs for attaching errors.~~ remove com.sun.jdi.VMDisconnectedException from reasonable places. Nov 14, 2017

Merge branch 'master' into andy_log_attach

6dfe372

yaohaizh previously approved these changes Nov 17, 2017

View reviewed changes

Merge branch 'master' into andy_log_attach

08cada7

akaroml requested changes Nov 17, 2017

View reviewed changes

revert changes to handlers.

8ffb8ed

andxu dismissed yaohaizh’s stale review via 8ffb8ed November 17, 2017 08:33

andxu added 2 commits November 17, 2017 16:41

Remove error notifications to vscode when VMDisconnectedException is …

a8755b8

…happening, since it is normal to have received terminated message during process vscode requests, return an empty response since the debug session is terminated.

Merge branch 'master' into andy_log_attach

380e745

testforstephen reviewed Nov 21, 2017

View reviewed changes

andxu added 7 commits November 21, 2017 14:54

fix typo

4ae9498

Merge remote-tracking branch 'origin/andy_log_attach' into andy_log_a…

a566665

…ttach

merge with async response change for handling VMDisconnectedException

c2ff2f9

set valid success to VMDisconnectedException

7079ece

Update ProtocolServer.java

546bc98

testforstephen previously approved these changes Nov 22, 2017

View reviewed changes

andxu and others added 2 commits November 22, 2017 14:32

Merge branch 'master' into andy_log_attach

ddc0d33

Merge branch 'master' into andy_log_attach

45f558a

akaroml requested changes Nov 29, 2017

View reviewed changes

akaroml added this to the 0.4.0 milestone Nov 29, 2017

replace complex logic on whenComplete

5aedf4c

andxu dismissed testforstephen’s stale review via 5aedf4c November 30, 2017 04:28

andxu added 2 commits December 1, 2017 02:30

This was referenced Dec 1, 2017

[VMDisconnectedException]Got IOException from Virtual Machine on ConfigurationDone request #53

Closed

error on continue request: Got IOException from Virtual Machine #33

Closed

akaroml approved these changes Dec 2, 2017

View reviewed changes

Merge branch 'master' into andy_log_attach

4b1fb4f

andxu merged commit 55e29be into master Dec 5, 2017

andxu deleted the andy_log_attach branch March 15, 2018 01:45

github-actions bot mentioned this pull request Nov 14, 2025

runInTerminal reverse-request missing cwd key #251

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove com.sun.jdi.VMDisconnectedException from reasonable places.#104

remove com.sun.jdi.VMDisconnectedException from reasonable places.#104
andxu merged 22 commits intomasterfrom
andy_log_attach

andxu commented Nov 14, 2017

Uh oh!

akaroml Nov 17, 2017

Uh oh!

testforstephen Nov 21, 2017

Uh oh!

akaroml Nov 29, 2017

Uh oh!

akaroml Nov 29, 2017

Uh oh!

akaroml Nov 29, 2017

Uh oh!

akaroml Nov 29, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -68,16 +70,32 @@ protected void dispatchRequest(Messages.Request request) {
		this.debugAdapter.dispatchRequest(request).whenComplete((response, ex) -> {

		@@ -68,16 +70,32 @@ protected void dispatchRequest(Messages.Request request) {
		this.debugAdapter.dispatchRequest(request).whenComplete((response, ex) -> {
		if (response != null) {

Conversation

andxu commented Nov 14, 2017

Uh oh!

akaroml Nov 17, 2017

Choose a reason for hiding this comment

Uh oh!

testforstephen Nov 21, 2017

Choose a reason for hiding this comment

Uh oh!

akaroml Nov 29, 2017

Choose a reason for hiding this comment

Uh oh!

akaroml Nov 29, 2017

Choose a reason for hiding this comment

Uh oh!

akaroml Nov 29, 2017

Choose a reason for hiding this comment

Uh oh!

akaroml Nov 29, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants