if listing the variable value of a large object fails, just display its basic info#385
Merged
testforstephen merged 1 commit intomicrosoft:mainfrom Sep 23, 2021
Merged
Conversation
… exception, just display its basic info
testforstephen
changed the title
jdneo
reviewed
Sep 23, 2021
Member
jdneo
left a comment
jdneo
left a comment
There was a problem hiding this comment.
Overall looks good to me. Just curious what's the behavior of Eclipse/IntelliJ for such case?
Contributor
Author
Nice concern. In eclipse, it shows a dialog about OOM and meanwhile the variable view shows an empty row for the exceptional variable.
In IJ, it uses async to display each variable and there is a never-ending loading message "Collecting data...". |
jdneo
approved these changes
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode-java-debug#1044
Since JDI does not provide an efficient way to query whether a variable is a large object or not. One way to mitigate this is to intercept OOM or timeout exceptions that occur when fetching variable information and display a placeholder on these failed variable segments. This way, the user still has the opportunity to view the basic variable information.
Before - Variables view just displays an Exception message.
After - Variables view still lists all variables, but displays a placeholder for the failed variable property.
