genpolicy: block all relative paths for copyFile requests#166
Merged
genpolicy: block all relative paths for copyFile requests#166
Conversation
99ae275 to
3541346
Compare
Signed-off-by: Saul Paredes <saulparedes@microsoft.com>
Signed-off-by: Saul Paredes <saulparedes@microsoft.com>
3541346 to
639c591
Compare
manuelh-dev
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream-missinglabel (orupstream-not-needed) has been set on the PR.Summary
This PR tightens the policy implementation with regards to directory traversal by prohibiting symlink sources that contain
...It's worth noting this fix has been added to check_directory_traversals, which is used by 2 code paths:
..would fail subsequent regexp validationTest Methodology
Tested locally using https://github.com/kata-containers/kata-containers/blob/main/src/tools/agent-ctl/README.md#examples.
Was able to see before this change how we can specify a copy file request with a symlink source pointing to
..Was able to see after this change how specifying a copy file request gets blocked