Skip to content

samples: update docker sample and shareName#177

Merged
Redent0r merged 2 commits intomsft-mainfrom
saulparedes/update_samples
May 13, 2024
Merged

samples: update docker sample and shareName#177
Redent0r merged 2 commits intomsft-mainfrom
saulparedes/update_samples

Conversation

@Redent0r
Copy link

@Redent0r Redent0r commented Apr 15, 2024

Update azure-file-secrets.yaml ans use better azureFile shareName

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • genPolicy only: Updated sample YAMLs' policy annotations, if applicable
  • The upstream-missing label (or upstream-not-needed) has been set on the PR.
Summary

Update azure-file-secrets.yaml ans use better azureFile shareName.

Merge alongside https://dev.azure.com/mariner-org/mariner/_git/mariner-aks-pipelines/pullrequest/18960 once tests pass

Links to CVEs
Test Methodology

https://dev.azure.com/mariner-org/mariner/_build/results?buildId=567375&view=results

@Redent0r Redent0r added upstream/missing PRs that are yet to be upstreamed upstream/not-needed PRs that will not be upstreamed (e.g. internal) and removed upstream/missing PRs that are yet to be upstreamed labels Apr 15, 2024
Update azure-file-secrets.yaml ans use better azureFile shareName

Signed-off-by: Saul Paredes <saulparedes@microsoft.com>
@Redent0r Redent0r force-pushed the saulparedes/update_samples branch from d15c92a to 1c2344a Compare May 10, 2024 21:15
@Redent0r Redent0r marked this pull request as ready for review May 10, 2024 22:17
@Redent0r Redent0r requested review from a team as code owners May 10, 2024 22:17
update docker sample annotation for latest image version

Signed-off-by: Saul Paredes <saulparedes@microsoft.com>
@Redent0r Redent0r force-pushed the saulparedes/update_samples branch from 1c2344a to 5f2bb03 Compare May 10, 2024 22:20
@Redent0r Redent0r changed the title genpolicy: update sample samples: update docker sample and shareName May 10, 2024
@Redent0r Redent0r merged commit 4b2ede3 into msft-main May 13, 2024
@Redent0r Redent0r deleted the saulparedes/update_samples branch May 13, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream/not-needed PRs that will not be upstreamed (e.g. internal)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants