Skip to content

node-builder: Fix SHIM_USE_DEBUG_CONFIG behavior#318

Merged
sprt merged 1 commit intomsft-mainfrom
sprt/fix-debug-build
Mar 3, 2025
Merged

node-builder: Fix SHIM_USE_DEBUG_CONFIG behavior#318
sprt merged 1 commit intomsft-mainfrom
sprt/fix-debug-build

Conversation

@sprt
Copy link

@sprt sprt commented Feb 24, 2025

Using a symlink would create a cycle after calling this script again when copying the final configuration at line 74 so we just use cp instead.

Also, I moved this block to the end of the file to properly override the final config file.

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Test Methodology

Local build

Using a symlink would create a cycle after calling this script again when
copying the final configuration at line 74 so we just use cp instead.

Also, I moved this block to the end of the file to properly override the final
config file.

Signed-off-by: Aurélien Bombo <abombo@microsoft.com>
@sprt sprt requested review from a team as code owners February 24, 2025 20:41
@sprt sprt added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Feb 24, 2025
@sprt sprt requested a review from manuelh-dev February 24, 2025 20:42
@sprt sprt merged commit 1a57b28 into msft-main Mar 3, 2025
51 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream/not-needed PRs that will not be upstreamed (e.g. internal)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants