Update ID generation logic to add dash between prefix and number #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with ID generation logic in the Keyborg library. Currently, IDs are generated using a letter prefix followed by an incrementing number, but this approach can lead to conflicts when multiple versions of the library are loaded in the same context.
Changes
KeyborgCoreconstructor from"c" + ++_lastIdto"c-" + ++_lastIdKeyborgprivate constructor from"k" + ++_lastIdto"k-" + ++_lastIdBenefits
Testing
The changes have been verified through:
This improvement helps avoid issues in applications that might load multiple versions of Keyborg, while keeping the implementation simple and maintaining the existing functionality.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.