fix: getLastFocusedProgrammatically returns the element even after the focusin event is processed #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e focusin event is processed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Keyborg saves the
lastFocusedProgrammaticallyelement whenelement.focus()is called, and then clears it when thefocusinevent happens. The result is that the value is cleared before a React app gets the focus event, so there's no reasonable way for the app to callgetLastFocusedProgrammaticallywhen it has a valid value.New Behavior
Only clear the
lastFocusedProgrammaticallyvalue the next time focus changes withoutelement.focus()being called. This leaves the value set between focus moves, and keeps its value useful to React apps.