Skip to content

Conversation

@andrueastman
Copy link
Contributor

@andrueastman andrueastman commented Sep 23, 2024

Fixes #333

Related to microsoft/kiota#5453

Resolves typing errors in library and generated code by updating the ParsableFactory type to be a type variable across the SDK.

Adds a generated project that validates that running the static type checker does not yield errors due to inconsistencies in the typing information used in the generated code and the libraries.

Sample run at https://github.com/microsoft/kiota-abstractions-python/actions/runs/10994899545

@andrueastman andrueastman requested a review from a team as a code owner September 23, 2024 13:10
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
36.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@andrueastman andrueastman merged commit a6f130d into andrueastman/resolvetypingerrors Sep 23, 2024
@andrueastman andrueastman deleted the andrueastman/addgenerationValidation branch September 23, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants