Skip to content

Conversation

@andrueastman
Copy link
Contributor

Related to microsoft/kiota#5729

Fixes failures in integration tests due to mypy failures in incorrect typing information for the following methods,

  • send_collection_of_primitive_async from RequestAdapter should have the type as the parameter type for ResponseType
  • Cleans up set_content_from_parsable to target parsable so that set_content_from_scalar can target scalars
  • adds missing type info for get_collection_of_primitive_values as well as the derived implementations
  • adds missing type info for get_collection_of_object_values as well as the derived implementations

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

@andrueastman andrueastman merged commit 92cf4c5 into main Nov 9, 2024
52 checks passed
@andrueastman andrueastman deleted the andrueastman/fixTypingErrors branch November 9, 2024 08:17
@andrueastman andrueastman linked an issue Nov 11, 2024 that may be closed by this pull request
@andrueastman andrueastman mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Typing questions

3 participants