Skip to content

fix: only use base_uri from http client #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 2 commits into from
Jun 26, 2025
Merged

fix: only use base_uri from http client #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b0ec30
fix: only use base_uri from http client
gavinbarron Jun 23, 2025
c312efe
Merge branch 'main' into fix/http-base-uri-initialization
gavinbarron Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/http/httpx/kiota_http/httpx_request_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,7 @@ def __init__(
if not http_client:
http_client = KiotaClientFactory.create_with_default_middleware()
self._http_client: httpx.AsyncClient = http_client
if not base_url:
base_url = str(http_client.base_url) if http_client.base_url is not None else ""
self._base_url: str = base_url
self._base_url: str = str(http_client.base_url) if http_client.base_url is not None else ""
if not observability_options:
observability_options = ObservabilityOptions()
self.observability_options = observability_options
Expand Down
5 changes: 4 additions & 1 deletion packages/http/httpx/tests/test_httpx_request_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,8 +449,11 @@ async def test_send_primitive_async_302_with_location_header_does_not_throw(
assert "location" in resp.headers
await request_adapter.send_primitive_async(request_info, "float", {})

def test_httpx_request_adapter_ignores_base_url_parameter(auth_provider):
request_adapter = HttpxRequestAdapter(auth_provider, base_url="https://no.com")
assert request_adapter.base_url == ""

def test_httpx_request_adapter_uses_http_client_base_url(auth_provider):
http_client = httpx.AsyncClient(base_url=BASE_URL)
request_adapter = HttpxRequestAdapter(auth_provider, http_client=http_client)
request_adapter = HttpxRequestAdapter(auth_provider, http_client=http_client, base_url="https://no.com")
assert request_adapter.base_url == BASE_URL