Ft compression handler #14 #1132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobala
requested review from
MIchaelMainer,
andrueastman,
baywet,
darrelmiller,
ddyett,
nikithauc,
peombwa,
ramsessanchez and
zengin
as code owners
baywet
requested changes
Feb 4, 2022
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Great work! Thanks for tackling this.
Can you add the middleware in the list here please?
baywet
requested changes
Feb 4, 2022
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
thanks for taking in the change, I forgot the options aspect, sorry about that
baywet
requested changes
Feb 7, 2022
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
thanks for taking in the changes, a few additional comments.
|
Kudos, SonarCloud Quality Gate passed!
|
baywet
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds compression handler
Fixes #14