Built-in support for multiple command loaders

[tjprescott]

Knack supports only a single command loader which makes it tricky to use in scenarios like Azure CLI which has several modules. Knack should work in a consistent way for single or multiple command modules.

[JonnyWaffles]

Hi all, is this project still being maintained? The above feature makes a lot of sense. Is knack still intended to be the framework Azure CLI development?

[tjprescott]

@myronfanqiu for comment.

[mmyyrroonn]

@jiasli for comment.

[jiasli]

Hi @tjprescott, is this causing any problem right now? Could you provide more info?

[tjprescott]

Knack itself only accepts a single command loader. Azure CLI works around this by creating a command loader that loads a bunch of other command loaders (and extension loaders). The ability to load one or more command loaders would make sense to be in Knack itself. This would allow other CLIs that use Knack to take advantage and would allow the CLI core to be simplified by pushing that logic into Knack.

[mjalas]

Hi all,

This issue seems to have existed for some time now already and I'm wondering about what the current timeline is for multiple command loaders to be supported in Knack?

The approach I've used so far is to inject the command loader through a default function that every plugin implements, which is called when each plugin is loaded in the main function of the CLI. This approach has worked well enough so far and the core of the plugin loading function is about 15 lines of code, so in that sense not much to maintain either. However, it would of course be nice if Knack itself would provide a "cleaner" way of doing this with Python code.

[masonhuemmer]

What is the status for this issue?