Fix warning/deprecated msg indentation in help text#167
Merged
jiasli merged 5 commits intomicrosoft:masterfrom Feb 17, 2020
Merged
Fix warning/deprecated msg indentation in help text#167jiasli merged 5 commits intomicrosoft:masterfrom
jiasli merged 5 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
@adewaleo @tjprescott Can you please take a look at this fix? Also the build failures seem unrelated to the change. |
Collaborator
|
@jiasli please take a look at this PR. |
Collaborator
|
We will plan it after Ignite. |
2 tasks
qwordy
reviewed
Oct 18, 2019
qwordy
approved these changes
Oct 24, 2019
|
The Travis CI build failed. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 167 in repo microsoft/knack |
|
I don't have permission to rerun CI. |
|
And it seems I don't have write access. So my approval is not sufficient. |
Contributor
Author
Contributor
Author
jiasli
approved these changes
Feb 11, 2020
Member
|
@atbagga , do you mind fix the test to pass the CI? https://travis-ci.org/microsoft/knack/jobs/648761811#L274 |
Contributor
Author
Done!! @jiasli |
Member
|
@haroldrandom , is it safe to merge to master? |
Look so. Please go ahead. |
fengzhou-msft
approved these changes
Feb 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164
Before the fix:
After the fix:
