Split out Pytest plugins#1106
Closed
andyleejordan wants to merge 102 commits into
Closed
Conversation
This is a _working_ test.
Extend Fabric’s Connection class with a new (and simple) command “cat” which return the value of a remote file as a string. Setup a Config for the Connection when creating it that echoes every command, disables the stdin forwarding (since we’re running under Pytest), and fixes the PATH since the remote commands don’t run under a login shell.
This could be extended to instead deploy a host of the specified distro. Most likely we’ll want a command-line parameter that the fixture uses to create a Node with the given requirements, and then tests will be skipped if their requirements aren’t met. Further more, the mark here is very simple. It can instead take keyword arguments, which would map to our metadata.
As supplying types for these would be supremely annoying.
Accidentally eliminated Fabric’s default overrides of Invoke by supplying my own config based on `invoke.Config` to Fabric. Oops.
The old-style was recently deprecated: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
It didn’t belong there in the first place!
andyleejordan
added
🛑 DO-NOT-MERGE
🆕 LISAv3
andyleejordan
force-pushed
the
andschwa/plugin-split
branch
3 times, most recently
from
04a2c59 to
dfa10b0
Compare
andyleejordan
force-pushed
the
andschwa/plugin-split
branch
from
0e2ded1 to
55d5929
Compare
Just forwards to Pytest, but hey!
Member
Author
|
All right, cool, did the subtree split and closing to open a new PR to main! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of #1065, which is still under review by @lpereira and @squirrelsc, but I need to open this to run the GitHub action for testing. This splits out the Pytest plugins per the TSD, which means we're close to being ready to upload to PyPi. Before that I need to do a subtree export and open a different PR to
mainso we can consolidate codebases.