Skip to content

[improvement] allow to use users' resource group which not create from lisa#2513

Merged
LiliDeng merged 1 commit into
mainfrom
lildeng/1_7_005
Jan 18, 2023
Merged

[improvement] allow to use users' resource group which not create from lisa#2513
LiliDeng merged 1 commit into
mainfrom
lildeng/1_7_005

Conversation

@LiliDeng
Copy link
Copy Markdown
Collaborator

@LiliDeng LiliDeng commented Jan 9, 2023

No description provided.

@LiliDeng LiliDeng requested a review from squirrelsc as a code owner January 9, 2023 03:34
@LiliDeng LiliDeng self-assigned this Jan 9, 2023
@LiliDeng LiliDeng changed the title [improvement] allow to use users' environment [improvement] allow to use users' resource group which not create from lisa Jan 9, 2023
Comment thread lisa/sut_orchestrator/azure/platform_.py Outdated
Comment thread lisa/sut_orchestrator/azure/platform_.py
@LiliDeng LiliDeng force-pushed the lildeng/1_7_005 branch 5 times, most recently from 8567905 to 010f386 Compare January 13, 2023 11:38
@LiliDeng LiliDeng requested a review from squirrelsc January 13, 2023 15:10
Comment thread lisa/sut_orchestrator/azure/common.py Outdated
@LiliDeng LiliDeng force-pushed the lildeng/1_7_005 branch 2 times, most recently from 52389b0 to f8f98c1 Compare January 14, 2023 13:11
@LiliDeng
Copy link
Copy Markdown
Collaborator Author

LiliDeng commented Jan 15, 2023

@avylove can we use a fixed version of flake8-bugbear, and update the version regularly? the failures shown in my PR were caused by new warnings B028 added in latest version of flake8-bugbear.

I have a quick fix here #2525

@LiliDeng LiliDeng requested a review from squirrelsc January 16, 2023 02:56
@LiliDeng LiliDeng merged commit dcc0ab6 into main Jan 18, 2023
@LiliDeng LiliDeng deleted the lildeng/1_7_005 branch January 18, 2023 04:42
@avylove
Copy link
Copy Markdown
Contributor

avylove commented Jan 18, 2023

@avylove can we use a fixed version of flake8-bugbear, and update the version regularly? the failures shown in my PR were caused by new warnings B028 added in latest version of flake8-bugbear.

I have a quick fix here #2525

#2533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants