Pylint: Enable eval-used#2514
Merged
Merged
Conversation
squirrelsc
reviewed
Jan 9, 2023
squirrelsc
reviewed
Jan 9, 2023
LiliDeng
reviewed
Jan 10, 2023
Contributor
Author
|
@squirrelsc , @LiliDeng Any issues with this? |
Contributor
Author
|
Runbook I used to for testing., just changed name: local test
notifier:
- type: html
environment:
environments:
- nodes:
- type: local
platform:
- type: ready
variable:
- name: timeout_value
value: 0
transformer:
- type: script
rename:
script_should_run: should_run
scripts:
- name: should_run
variables:
- timeout_value
script: int(timeout_value) <= 0 |
Contributor
|
It needs to be tested with 1) gen1/gen2, 2) hibernate or rdma. Please let Lili know, if you don't know which test is suitable for this testing. |
LiliDeng
approved these changes
Jan 23, 2023
LiliDeng
requested changes
Jan 23, 2023
Collaborator
LiliDeng
left a comment
There was a problem hiding this comment.
will double check once back from holiday, thanks!
squirrelsc
previously approved these changes
Feb 27, 2023
LiliDeng
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eval()allows arbitrary code execution and should be avoided. This adds a Pylint check and removed cases where is was used. Most of those were simple changes, butScriptTransformerrequired restricting what user input can do. simpleeval was used as it's close to the implementation of a mini-language without effort of creating one.