Pylint: enable missing-timeout#2539
Merged
Merged
Conversation
avylove
force-pushed
the
pylint_10
branch
2 times, most recently
from
1c2ade5 to
3652333
Compare
squirrelsc
reviewed
Feb 22, 2023
squirrelsc
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables missing-timeout check to identify cases where requests is used without timeout values since this can hang waiting for a response.
I used 60 as the timeout, which is too much. I think 30 would be better, but wanted to be very conservative and see how others felt.