Skip to content

BumpDeps: mypy#2545

Closed
github-actions[bot] wants to merge 2 commits into
mainfrom
bumpdeps/mypy_3982549804
Closed

BumpDeps: mypy#2545
github-actions[bot] wants to merge 2 commits into
mainfrom
bumpdeps/mypy_3982549804

Conversation

@github-actions
Copy link
Copy Markdown

Created by Github Action

squirrelsc
squirrelsc previously approved these changes Jan 23, 2023
@avylove
Copy link
Copy Markdown
Contributor

avylove commented Jan 24, 2023

Brought in the typing changes from the unpinning PR. This should be ready to go.

@squirrelsc
Copy link
Copy Markdown
Contributor

@LiliDeng When you have time, please let Avram know which scenarios should be covered. For the marketplace image, SIG loading tests, it may need to run multiple test cases together, which will load image object from memory.

@avylove avylove mentioned this pull request Jan 30, 2023
@avylove avylove force-pushed the bumpdeps/mypy_3982549804 branch from fa09b81 to 2d11181 Compare January 30, 2023 15:34
@avylove avylove mentioned this pull request Feb 6, 2023
@avylove avylove force-pushed the bumpdeps/mypy_3982549804 branch 2 times, most recently from 2cbde7e to 6efe1d7 Compare February 13, 2023 14:20
@avylove avylove mentioned this pull request Feb 13, 2023
@avylove avylove force-pushed the bumpdeps/mypy_3982549804 branch 2 times, most recently from 6af232c to 0238a7d Compare February 27, 2023 21:37
@avylove avylove force-pushed the bumpdeps/mypy_3982549804 branch from 0238a7d to 1019849 Compare March 6, 2023 15:25
@avylove avylove force-pushed the bumpdeps/mypy_3982549804 branch from 1019849 to de8c44f Compare March 13, 2023 22:54
Comment thread lisa/environment.py
@avylove avylove force-pushed the bumpdeps/mypy_3982549804 branch from de8c44f to 5d6686b Compare March 20, 2023 14:00
@avylove avylove force-pushed the bumpdeps/mypy_3982549804 branch from 5d6686b to d2befb6 Compare April 26, 2023 13:55
@avylove
Copy link
Copy Markdown
Contributor

avylove commented Apr 26, 2023

@squirrelsc Rebased again. This basic maintenance PR is now 3 months old. and we're running a version of Mypy that was superseded a year ago.

@squirrelsc
Copy link
Copy Markdown
Contributor

It contains many changes, we don't have bandwidth to test regressions. Please disable related rules, and focus on upgrading mypy version in this PR.

@avylove
Copy link
Copy Markdown
Contributor

avylove commented Apr 26, 2023

That's what I am doing. These are just the changes to make it pass. It keeps growing because it hasn't been merged in so long and bad code keep getting implemented. This is why you have to keep up with dependencies.

@squirrelsc
Copy link
Copy Markdown
Contributor

Please split changes into separated PRs, and provide tested scenarios. We can evaluate the test coverage and remaining risks.

@avylove
Copy link
Copy Markdown
Contributor

avylove commented Apr 26, 2023

What is there to split? These are the changes need to work with the new version. This is a relatively simple PR for anyone with intermediate Python skills to review.

@squirrelsc
Copy link
Copy Markdown
Contributor

Close the old PR.

@squirrelsc squirrelsc closed this Jul 22, 2025
@squirrelsc squirrelsc deleted the bumpdeps/mypy_3982549804 branch September 4, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants