Refine quick install lisa scripts#4479
Merged
Merged
Conversation
- installers/quick-install-dev.ps1: Windows-native dev install (clone, .venv, pip install -e .[azure,libvirt], writes .vscode/launch.json + settings.json for F5 debug; libvirt extra auto-falls back, -SkipLibvirt/-NoClone/-SkipLaunchJson switches) - .github/prompts/install-lisa.prompt.md: add WSL Bootstrap and Windows Dev sections; add troubleshooting entry for debugpy F5 hang when system Python is used instead of the venv
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new “quick install” entrypoints for Windows users: a WSL bootstrapper that installs/uses a WSL distro and runs quick-install.sh inside it, and a Windows-native developer setup script that creates an editable .venv install and writes VS Code debug configuration. It also updates the install prompt documentation to describe these new flows.
Changes:
- Added
quick-install-wsl.ps1to bootstrap WSL + runinstallers/quick-install.shinside a selected distro/branch. - Added
quick-install-dev.ps1to set up a Windows editable install in.venvand generate.vscode/settings.json+launch.json. - Updated
.github/prompts/install-lisa.prompt.mdwith new WSL and Windows-dev instructions and troubleshooting notes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| installers/quick-install-wsl.ps1 | New PowerShell script to install/validate a WSL distro and run quick-install.sh within it. |
| installers/quick-install-dev.ps1 | New PowerShell script to create a Windows dev venv, install LISA editable, and scaffold VS Code debug settings. |
| .github/prompts/install-lisa.prompt.md | Documentation updates describing the new WSL bootstrap and Windows dev install flows. |
Comments suppressed due to low confidence (2)
installers/quick-install-dev.ps1:177
- The generated VS Code JSON will likely be invalid because Windows paths need backslashes escaped as
\\in JSON. The current-replace '\\', '\\'does not double the backslashes, sopython.defaultInterpreterPathmay contain sequences like\cthat break JSON parsing. Consider using a JSON serializer (ConvertTo-Json) or correctly replacing\with\\before writing settings.json.
$venvPythonForJson = (Join-Path $InstallPath ".venv\Scripts\python.exe") -replace '\\', '\\'
$cwdForJson = $InstallPath -replace '\\', '\\'
installers/quick-install-dev.ps1:103
- When reusing an existing repo,
git checkout $Branchcan fail if the branch doesn’t exist locally (common when switching to a new remote branch). Consider switching/creating the local branch fromorigin/$Branch(e.g.,git switch --track -c $Branch origin/$Branchor equivalent) before pulling.
& git.exe fetch origin $Branch --quiet
& git.exe checkout $Branch --quiet
& git.exe pull --ff-only origin $Branch --quiet
johnsongeorge-w
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results