Skip to content

Refine quick install lisa scripts#4479

Merged
LiliDeng merged 2 commits into
mainfrom
feature/quickinstall-platforms_110526_152936
May 14, 2026
Merged

Refine quick install lisa scripts#4479
LiliDeng merged 2 commits into
mainfrom
feature/quickinstall-platforms_110526_152936

Conversation

@LiliDeng
Copy link
Copy Markdown
Collaborator

@LiliDeng LiliDeng commented May 13, 2026

Description

Related Issue

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation update

Checklist

  • Description is filled in above
  • No credentials, secrets, or internal details are included
  • Peer review requested (if not, add required peer reviewers after raising PR)
  • Tests executed and results posted below

Test Validation

Key Test Cases:

Impacted LISA Features:

Tested Azure Marketplace Images:

Test Results

Image VM Size Result
PASSED / FAILED / SKIPPED

LiliDeng added 2 commits May 12, 2026 10:01
- installers/quick-install-dev.ps1: Windows-native dev install (clone, .venv, pip install -e .[azure,libvirt], writes .vscode/launch.json + settings.json for F5 debug; libvirt extra auto-falls back, -SkipLibvirt/-NoClone/-SkipLaunchJson switches)

- .github/prompts/install-lisa.prompt.md: add WSL Bootstrap and Windows Dev sections; add troubleshooting entry for debugpy F5 hang when system Python is used instead of the venv
Copilot AI review requested due to automatic review settings May 13, 2026 02:58
@LiliDeng LiliDeng requested a review from johnsongeorge-w as a code owner May 13, 2026 02:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds new “quick install” entrypoints for Windows users: a WSL bootstrapper that installs/uses a WSL distro and runs quick-install.sh inside it, and a Windows-native developer setup script that creates an editable .venv install and writes VS Code debug configuration. It also updates the install prompt documentation to describe these new flows.

Changes:

  • Added quick-install-wsl.ps1 to bootstrap WSL + run installers/quick-install.sh inside a selected distro/branch.
  • Added quick-install-dev.ps1 to set up a Windows editable install in .venv and generate .vscode/settings.json + launch.json.
  • Updated .github/prompts/install-lisa.prompt.md with new WSL and Windows-dev instructions and troubleshooting notes.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
installers/quick-install-wsl.ps1 New PowerShell script to install/validate a WSL distro and run quick-install.sh within it.
installers/quick-install-dev.ps1 New PowerShell script to create a Windows dev venv, install LISA editable, and scaffold VS Code debug settings.
.github/prompts/install-lisa.prompt.md Documentation updates describing the new WSL bootstrap and Windows dev install flows.
Comments suppressed due to low confidence (2)

installers/quick-install-dev.ps1:177

  • The generated VS Code JSON will likely be invalid because Windows paths need backslashes escaped as \\ in JSON. The current -replace '\\', '\\' does not double the backslashes, so python.defaultInterpreterPath may contain sequences like \c that break JSON parsing. Consider using a JSON serializer (ConvertTo-Json) or correctly replacing \ with \\ before writing settings.json.
    $venvPythonForJson = (Join-Path $InstallPath ".venv\Scripts\python.exe") -replace '\\', '\\'
    $cwdForJson        = $InstallPath -replace '\\', '\\'

installers/quick-install-dev.ps1:103

  • When reusing an existing repo, git checkout $Branch can fail if the branch doesn’t exist locally (common when switching to a new remote branch). Consider switching/creating the local branch from origin/$Branch (e.g., git switch --track -c $Branch origin/$Branch or equivalent) before pulling.
                & git.exe fetch origin $Branch --quiet
                & git.exe checkout $Branch --quiet
                & git.exe pull --ff-only origin $Branch --quiet

Comment thread installers/quick-install-dev.ps1
Comment thread .github/prompts/install-lisa.prompt.md
@LiliDeng LiliDeng merged commit 5aca8d5 into main May 14, 2026
62 checks passed
@LiliDeng LiliDeng deleted the feature/quickinstall-platforms_110526_152936 branch May 14, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants