LVBS: Revise VTL switch loop and add run_thread support#541
Merged
Conversation
jstarks
reviewed
Dec 6, 2025
jstarks
reviewed
Dec 6, 2025
6eff7d6 to
bd87679
Compare
jstarks
approved these changes
Dec 8, 2025
bd87679 to
a298043
Compare
sangho2
added a commit
that referenced
this pull request
Jan 22, 2026
This PR fixes some bugs in the VTL switching loop and improve its reliability and performance. Specifically, this PR uses assembly code to carefully switch between VTLs while saving/restoring VTL0 registers. This PR removes some unreliable stack manipulation code we had before. In addition, this PR makes it clear that we no longer store the VTL1 state in per-core storage. Note: this PR and #541 should be merged together since #541 suffers from a crash due to some bugs that this PR is fixing. --------- Co-authored-by: Sangho Lee <sanghle@microsoft.com>
dc8b467 to
2324e64
Compare
added 8 commits
January 24, 2026 02:14
This PR adds `run_thread` support for LVBS platform and revise its syscall handling routine based on Linux userland platform's syscall handling. It has suppressed new page table creation for now because it needs to be done by the runner via an upcall (userspace support still exists, but doesn't create a separate one for each TA instance for now). --------- Co-authored-by: Sangho Lee <sanghle@microsoft.com>
4a51c09 to
b10c305
Compare
wdcui
reviewed
Jan 24, 2026
Member
wdcui
left a comment
There was a problem hiding this comment.
Overall, the code looks good to me. I left some comments below.
wdcui
approved these changes
Jan 26, 2026
Member
wdcui
left a comment
There was a problem hiding this comment.
Thank you for making efforts to improve this PR!
tgopinath-microsoft
approved these changes
Jan 26, 2026
|
🤖 SemverChecks 🤖 Click for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revises VTL switch loop including VTL0 state saving/restoring, and
adds
run_threadsupport.This PR uses assembly code to carefully switch between VTLs while
saving/restoring VTL0 general-purpose registers and extended states.
Also, it adds
run_threadsupport for the LVBS platform and revises the syscallhandling routine based on that of the Linux userland platform.