Add handlers for OP-TEE TA request and execution result#564
Closed
sangho2 wants to merge 52 commits intosanghle/lvbs/optee_msg_handler_1from
Closed
Add handlers for OP-TEE TA request and execution result#564sangho2 wants to merge 52 commits intosanghle/lvbs/optee_msg_handler_1from
sangho2 wants to merge 52 commits intosanghle/lvbs/optee_msg_handler_1from
Conversation
added 19 commits
December 12, 2025 03:58
sangho2
changed the title
sangho2
force-pushed
the
sanghle/lvbs/optee_msg_handler_2
branch
from
bd37e2f to
9c7a30d
Compare
sangho2
force-pushed
the
sanghle/lvbs/optee_msg_handler_2
branch
from
9c7a30d to
0f0c934
Compare
added 15 commits
January 8, 2026 05:53
sangho2
force-pushed
the
sanghle/lvbs/optee_msg_handler_2
branch
from
2cd83ef to
5b4fcf9
Compare
sangho2
force-pushed
the
sanghle/lvbs/optee_msg_handler_2
branch
from
8b2b117 to
a91950e
Compare
sangho2
force-pushed
the
sanghle/lvbs/optee_msg_handler_2
branch
from
a91950e to
8700931
Compare
wdcui
reviewed
Jan 19, 2026
| /// # Panics | ||
| /// | ||
| /// Panics if XSAVE areas are not allocated or if an invalid VTL value is provided. | ||
| pub fn save_extended_states(&self, vtl: u8) { |
Contributor
Author
There was a problem hiding this comment.
Intel calls it Extended States
litebox_runner_lvbs/src/lib.rs
Outdated
| vtl_switch_loop_entry(platform) | ||
| } | ||
|
|
||
| // Tentative OP-TEE message handler upcall implementation. |
Member
There was a problem hiding this comment.
Nit: should we move this comment down to be right next to the implementation?
| ) -> Result<i64, litebox_common_linux::errno::Errno> { | ||
| let smc_args_addr: usize = smc_args_addr.truncate(); | ||
| match optee_msg_handler(smc_args_addr) { | ||
| Ok(smc_arg) => { |
Member
There was a problem hiding this comment.
optee_msg_handler returns an smc_arg? I would expect a handler to return a result.
|
|
||
| #[inline] | ||
| fn page_align_down(address: u64) -> u64 { | ||
| fn page_align_down_u64(address: u64) -> u64 { |
Member
There was a problem hiding this comment.
Why do we need to change the function name?
| data[1] = (msg_arg.get_param_value(0)?.b).truncate(); | ||
| data[2] = (msg_arg.get_param_value(1)?.a).truncate(); | ||
| data[3] = (msg_arg.get_param_value(1)?.b).truncate(); | ||
| (Some(TeeUuid::from_u32_array(data)), 2) |
| read_data_from_shm(&shm_info, &mut data)?; | ||
| UteeParamOwned::MemrefInput { data: data.into() } | ||
| } | ||
| OpteeMsgAttrType::TmemOutput | OpteeMsgAttrType::RmemOutput => { |
Member
There was a problem hiding this comment.
Minot: It doesn't save much by first handling Tmem and Rmem together and then handling them separately. It might be easier to just handle each case one by one.
| /// Note that we use this function for handing TA requests and in this context | ||
| /// `OpteeMsgParamTmem` and `OpteeMsgParamRmem` are equivalent because every shared memory | ||
| /// reference accessible by TAs must be registered in advance. | ||
| /// `OpteeMsgParamTmem` is matter for the registration of shared memory regions. |
| /// | ||
| /// `rmem.offs` must be an offset within the shared memory region registered with `rmem.shm_ref` before | ||
| /// and `rmem.offs + rmem.size` must not exceed the size of the registered shared memory region. | ||
| /// All addresses this function returns are page aligned and virtually contiguous within the normal world but |
Member
There was a problem hiding this comment.
If we don't trust the normal world, why does it matter if the memory is virtually contiguous in the normal world?
sangho2
force-pushed
the
sanghle/lvbs/optee_msg_handler_1
branch
from
20a424a to
42500bb
Compare
Contributor
Author
|
Note. This PR cannot be easily merged because #555 has been changed a lot. I'll cherry pick it once approved. |
sangho2
force-pushed
the
sanghle/lvbs/optee_msg_handler_1
branch
from
4cecf50 to
4d0df5e
Compare
Contributor
Author
|
Since this PR's base branch has been heavily changed, I'll close it and create a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds handlers for OP-TEE TA request and its execution result. It also has a runner-side
controller that leverages all OP-TEE SMC/messages handlers to deal with OP-TEE calls from
the normal world. Currently, this controller is no-op because it should be invoked via
an upcall from the platform and it relies on run_thread, both are in different PRs.