Introduce lower bound on attrs version#179
Merged
Merged
Conversation
`import attrs` is only available in versions 21.3.0 and newer
karthiknadig
approved these changes
Mar 6, 2023
brettcannon
approved these changes
Mar 6, 2023
Member
Yes, as your installer's resolver will have to make sure that any version of a distribution that gets installed is compatible with all requirements for that distribution. Basically pip has to walk the dependency graph and make sure whatever it chooses to install for |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lsprotocoluses theimport attrsAPI which was only introduced inv21.3.0.This PR sets a minimum version for attrs in the python package's
pyproject.tomlto hopefully guard against issues like this one in the future.Question: Is it sufficient to rely on the version bound set here to ensure the correct version is also installed for
pyglsandesbonio? Or since both downstream packages alsoimport attrsthemselves, is it more correct to have a version bound set in bothpyglsandesbonio? 🤔