Skip to content

Add customization to CompletionItemKind#359

Merged
karthiknadig merged 2 commits into
microsoft:mainfrom
karthiknadig:fix-field1
Jun 11, 2024
Merged

Add customization to CompletionItemKind#359
karthiknadig merged 2 commits into
microsoft:mainfrom
karthiknadig:fix-field1

Conversation

@karthiknadig
Copy link
Copy Markdown
Member

@karthiknadig karthiknadig commented Jun 11, 2024

Fixes #344

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Jun 11, 2024
@karthiknadig karthiknadig self-assigned this Jun 11, 2024
@karthiknadig karthiknadig requested a review from anthonykim1 June 11, 2024 17:42
@karthiknadig karthiknadig marked this pull request as ready for review June 11, 2024 17:42
@karthiknadig karthiknadig enabled auto-merge (squash) June 11, 2024 17:42
@karthiknadig karthiknadig merged commit c65a292 into microsoft:main Jun 11, 2024
@karthiknadig karthiknadig deleted the fix-field1 branch August 9, 2024 16:32
debonte added a commit that referenced this pull request Jul 23, 2025
Backing out the change in
#359 which was motivated by
#344.

Dirk explains at
microsoft/language-server-protocol#2149 (comment)
that `CompletionItemKind` doesn't support custom values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change Sequence[CompletionItemKind] to Sequence[CompletionItemKind | int]?

2 participants