Skip to content

Support HTML comments & embedded images#101

Merged
vitru merged 14 commits into
microsoft:masterfrom
bergbria:user/bberger/htmlComments
Aug 28, 2019
Merged

Support HTML comments & embedded images#101
vitru merged 14 commits into
microsoft:masterfrom
bergbria:user/bberger/htmlComments

Conversation

@bergbria
Copy link
Copy Markdown
Contributor

@bergbria bergbria commented Jun 26, 2019

  1. Preserves HTML in replies when adding comments to work items
  2. For both replies and the original description (if the description is configured to be html), ensure that any embedded tags in the original email HTML are preserved and rendered correctly in the work item
  3. Numbers 1 & 2 are both gated behind a new config settings (EnableExperimentalHtmlFeatures)
  4. Number 2 currently requires including attachments when first creating the work item rather than in subsequent edits.

@msftclas
Copy link
Copy Markdown

msftclas commented Jun 26, 2019

CLA assistant check
All CLA requirements met.

Comment thread Mail2Bug/Email/EmailBodyProcessingUtils.cs Outdated
Comment thread Mail2Bug/Email/EmailBodyProcessingUtils.cs
Comment thread Mail2Bug/packages.config
@@ -1,5 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="CsQuery" version="1.3.4" targetFramework="net45" />
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AngleSharp seems to be the better-maintained library at this point. After implementing with csquery, I got AngleSharp mostly working but ran into some text encoding issues (e.g. fancy quotes weren't rendered correctly). My inclination is leave csquery in use barring functional issues but am open to discussion.

@bergbria bergbria changed the title Support creating comments as HTML instead of plain text Support HTML comments & embedded images Jul 3, 2019
Comment thread Mail2Bug/MessageProcessingStrategies/SimpleBugStrategy.cs
@vitru vitru merged commit 67ad092 into microsoft:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants