feat(magika): make magika an optional dependency#1355
Open
SyedaAnshrahGillani wants to merge 4 commits intomicrosoft:mainfrom
Open
feat(magika): make magika an optional dependency#1355SyedaAnshrahGillani wants to merge 4 commits intomicrosoft:mainfrom
SyedaAnshrahGillani wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Author
@microsoft-github-policy-service agree |
|
Of all PRs I'd like to see merged for this repo, this is the one I definitely would like to see merged the most. |
josteink
reviewed
Nov 21, 2025
Moved 'magika' dependency to optional dependencies section.
|
Could this PR get some love, pretty please? @afourney Calling in a favour as a .NET member and otherwise MS champion in GNU Emacs 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request makes the magika library an optional dependency in the markitdown package.
Previously, magika (and its dependency onnxruntime) was a mandatory installation, even for users who
did not utilize its functionality.
By making magika optional, users can now choose to install it only if they require its features,
leading to a smaller and more efficient installation for most users.
Changes:
it, gracefully skipping its functionality if not installed.