fix: use lmdb_get to access already loaded data without re-reading#243
Open
Robert-Forrest wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: use lmdb_get to access already loaded data without re-reading#243Robert-Forrest wants to merge 2 commits intomicrosoft:mainfrom
Robert-Forrest wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Author
@microsoft-github-policy-service agree company="Materials Nexus" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR is a fix for the following kind of error:
which started occurring following the release of this change to LMDB: jnwatson/py-lmdb@2b26c9f, making opening the same environment more than once an error.
An alternative fix to this issue would be to pin the lmdb version used by mattergen to be <2.0.0, but then we remain vulnerable to the kinds of issues the change to lmdb aims to avoid (e.g. potential segfaults).
As far as I understand, Mattergen evaluation may be blocked in many environments currently, due to installation potentially picking up the latest lmdb version.