Use uncached memory on Rocm platform to avoid hang #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the contribution, could you tell us which test is hang. Then we could verify in our env |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the MSCCLPP_DEVICE_HIP preprocessor macro was undefined in semaphore.cc, causing incorrect memory allocation behavior on ROCm platforms. The fix replaces it with the standard HIP platform macro __HIP_PLATFORM_AMD__.
Key Changes:
- Replaced
MSCCLPP_DEVICE_HIPwith__HIP_PLATFORM_AMD__in semaphore.cc to fix undefined macro usage
Contributor
|
Did a simple test in our env. I think you are right. |
Binyang2014
approved these changes
Dec 24, 2025
chhwang
approved these changes
Dec 24, 2025
Contributor
chhwang
left a comment
chhwang
left a comment
There was a problem hiding this comment.
A better way is including <mscclpp/device.hpp> here but this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSCCLPP_DEVICE_HIP is undefined because it is defined in device.hpp