FIX: Executemany String corruption on Unix systems + tests#217
Merged
bewithgaurav merged 25 commits intomainfrom Sep 8, 2025
Merged
FIX: Executemany String corruption on Unix systems + tests#217bewithgaurav merged 25 commits intomainfrom
bewithgaurav merged 25 commits intomainfrom
Conversation
… bewithgaurav/fix_blank_columns
… bewithgaurav/fix_executemany
…icrosoft/mssql-python into bewithgaurav/fix_executemany
… bewithgaurav/fix_blank_columns
…icrosoft/mssql-python into bewithgaurav/fix_blank_columns
…icrosoft/mssql-python into bewithgaurav/fix_executemany
sumitmsft
previously approved these changes
Sep 5, 2025
The base branch was changed.
gargsaumya
approved these changes
Sep 8, 2025
sumitmsft
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
Fix string handling in executemany batch operations on Unix systems
Issue:
executemanywas corrupting string data on Unix/macOS due to encoding mismatch in batch parameter binding. Strings were either truncated or returned garbage data.Root Cause:
In
BindParameterArrayfunction,std::wstring(UTF-32 on Unix) was directly copied toSQLWCHARbuffers (UTF-16) without proper encoding conversion, while single parameter binding inexecutecorrectly usedWStringToSQLWCHAR().Fix:
BindParameterArrayforSQL_C_WCHARcaseWStringToSQLWCHAR()for proper UTF-32 → UTF-16 conversionImpact:
executeandexecutemany