Merged
Conversation
Previously, allowTrailingCommas only allowed trailing commas in objects.
Previously, it only failed the test if an error's code was "undefined".
Contributor
|
Makes sense, thanks @sqs ! |
Contributor
Author
|
Thanks for the quick merge! BTW we are shipping this in Sourcegraph Server for users and admins to edit config. It works great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, allowTrailingCommas only allowed trailing commas in objects, and it would still return errors for JSON like
[1, 2, ]. This was surprising to me as a user. Is there a reason for allowing trailing commas in objects but not arrays?Also fixes the
assertValidParsehelper. It was not failing even when there were parse errors (because it only failed if there were parse errors AND the first parse error's code was"undefined"; I couldn't find a case where that would be true).