Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces two new actions: one for setting up vcpkg and another for setting up CMake, along with updates to documentation and CI workflow files.
- Implements a vcpkg setup action with download, SHA512 verification, bootstrapping, and caching.
- Implements a CMake setup action that supports resolving the latest version, hash verification, caching, and optional PATH updates.
- Updates action YAMLs, README documents, and CI workflows to integrate and test these new actions.
Reviewed Changes
Copilot reviewed 11 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/setup-vcpkg/index.js | Implements vcpkg setup with download logic, manual hash verification, extraction, bootstrap, and caching. |
| src/setup-cmake/index.js | Implements CMake setup with version resolution, optional Terrapin tool integration, download, verification, extraction, caching, and PATH setup. |
| actions/setup-vcpkg/action.yml | Defines inputs, outputs, and runtime configuration for the setup-vcpkg action. |
| actions/setup-vcpkg/README.md | Provides usage instructions and details for the setup-vcpkg action. |
| actions/setup-cmake/action.yml | Configures inputs, outputs, and runtime details for the setup-cmake action. |
| actions/setup-cmake/README.md | Documents the setup-cmake action features, inputs, outputs, and example usage scenarios. |
| README.md | Updates the list of available actions with usage details and platform limitations. |
| .github/workflows/build.yml | Adds Linux and Windows CI jobs to build, lint, test, and verify the actions. |
| .github/actions/locate-vcvarsall-and-setup-env/update_environment.py | Introduces a script for updating GitHub Actions environment variables based on a vcvarsall setup output. |
| .github/actions/locate-vcvarsall-and-setup-env/action.yml | Provides configuration for locating vcvarsall and setting up the environment in Windows workflows. |
Files not reviewed (4)
- .github/actions/locate-vcvarsall-and-setup-env/locate_vcvarsall.bat: Language not supported
- package.json: Language not supported
- test/cpp/build.bat: Language not supported
- test/cpp/main.cpp: Language not supported
jywu-msft
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new Github Action: setup-cmake