Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two specific issues in the setup-build-tools action: normalizing non-semver compliant vcpkg versions and correctly locating the cmake binary path on macOS systems.
- Adds vcpkg version normalization to handle leading zeros in version strings (e.g., "2025.08.27" → "2025.8.27")
- Implements platform-specific cmake binary path resolution for macOS systems
- Introduces comprehensive unit tests for both new functions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/setup-build-tools/index.js | Adds vcpkg version normalization and macOS cmake path handling functions with updated exports |
| test/setup-build-tools/vcpkg-version.test.js | Unit tests for vcpkg version normalization edge cases |
| test/setup-build-tools/index.test.js | Unit tests for platform-specific cmake binary path resolution |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bmehta001
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in the setup-build-tools action:
The vcpkg version is normalized to be semver compliant, so that it can be correctly handled by the @actions/tool-cache package. @actions/tool-cache package uses npm's semver package to parse such versions. However, vcpkg's version number is usually like "2025.08.27"(in YYYY.MM.DD format), which is not acceptable. Because there is an extra zero in the month part.
The cmake binary path is correctly located on macOS.
Unit tests have been added for both fixes.