[OpenVINO EP] Use OpenVINO cmake#19184
Conversation
ilya-lavrenov
force-pushed
the
use-openvino-cmake
branch
4 times, most recently
from
429da9f to
313db2f
Compare
|
/azp run Linux OpenVINO CI Pipeline |
|
Commenter does not have sufficient privileges for PR 19184 in repo microsoft/onnxruntime |
ilya-lavrenov
force-pushed
the
use-openvino-cmake
branch
from
313db2f to
379d1ae
Compare
|
@jywu-msft @preetha-intel could you please help with review? |
|
/azp run Linux OpenVINO CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ilya-lavrenov
force-pushed
the
use-openvino-cmake
branch
from
379d1ae to
c3913b9
Compare
|
Fixed code style issue |
| message(FATAL_ERROR "[Couldn't locate OpenVINO] OpenVINO may not have been initialized") | ||
| endif() | ||
|
|
||
| # Check OpenVINO version for support |
There was a problem hiding this comment.
The openvino Version is critical in get_capability of OVEP. It will break the execution flow. Its not advisable to remove the OPENVINO_VERSION
There was a problem hiding this comment.
See changes in onnxruntime/core/providers/openvino/ov_versions/capability.cc where OpenVINO version is extracted from OpenVINO headers. No needs to weird cmake logic to pass OpenVINO version via cmake
| file(READ $ENV{INTEL_OPENVINO_DIR}/deployment_tools/inference_engine/version.txt VER) | ||
| endif() | ||
|
|
||
| if (NOT DEFINED ENV{INTEL_OPENVINO_DIR}) |
There was a problem hiding this comment.
This ensures whether OPENVINO is sourced into the env. Not advisable to remove as it might end up with crash
There was a problem hiding this comment.
INTEL_OPENVINO_DIR is not defined in many distribution types like conda-forge, brew etc.
It's defined only by OpenVINO archive.
In order to check OpenVINO version, you must either use OpenVINO_VERSION vars from OpenVINOConfig.cmake or OpenVINO headers (openvino/core/version.hpp).
Please, see other changes where I've added version check in C++ files.
|
@jywu-msft @sfatimar @preetha-intel please, review and help to merge. |
I can help merge. @sfatimar, @preetha-intel can you review and let me know? thanks. |
|
/azp run Linux OpenVINO CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Replaced by #19966, which also contains this change. |
3 participants
Description
Current OpenVINO master removes InferenceEngine and ngraph as deprecated components (replaced by merged OpenVINO component). So, cmake scripts need to be adjusted to be ready for this change