Skip to content

Update abseil to a release tag and register neural_speed#19255

Merged
snnn merged 3 commits intomainfrom
snnn/update_absl
Jan 24, 2024
Merged

Update abseil to a release tag and register neural_speed#19255
snnn merged 3 commits intomainfrom
snnn/update_absl

Conversation

@snnn
Copy link
Contributor

@snnn snnn commented Jan 24, 2024

Description

Update abseil to a release tag and register neural_speed to CG.

Motivation and Context

Now we are using a non-relesed version of abseil. Using a tag is better.

@snnn snnn requested a review from a team as a code owner January 24, 2024 04:46
@snnn snnn requested a review from a team January 24, 2024 04:46
@pranavsharma
Copy link
Contributor

Where is neural speed used? Can you write it in the PR desc?

@edgchen1
Copy link
Contributor

Where is neural speed used? Can you write it in the PR desc?

It's a dependency added by this PR:
#19016

The library is used in the x64 MatMulNBits implementation.

@snnn
Copy link
Contributor Author

snnn commented Jan 24, 2024

Neural speed is an open source library that was introduced in PR #19016 . The PR was made by Intel, and there was some left job for compliance stuffs. I told them they can merged the PR first and I would take care of the remaining compliance things. That's what this PR is doing.
So, in fact this PR doesn't introduce new dependencies to ORT. The PR is to finish some registration work.

@snnn
Copy link
Contributor Author

snnn commented Jan 24, 2024

Later on I will also create a PR to update https://github.com/microsoft/onnxruntime/blob/main/ThirdPartyNotices.txt .

@pranavsharma
Copy link
Contributor

Later on I will also create a PR to update https://github.com/microsoft/onnxruntime/blob/main/ThirdPartyNotices.txt .

Any reason we need a separate PR for ThirdPartyNotices? It'll be nice to have a single PR that shows all the files that need to be updated to incorporate a new 3P dep. This way it can be used as a reference PR to add new deps.

@snnn
Copy link
Contributor Author

snnn commented Jan 24, 2024

The procedure is: first we should register any new dependency to CG. Then CG will use the information to go through some internal review. During the process I will also need to provide some additional information. Then after the review is done, we update the ThirdPartyNotices.txt. You may think the internal process is to ensure the text that is adding to ThirdPartyNotices.txt is accurate.

@snnn snnn merged commit bc54ad3 into main Jan 24, 2024
@snnn snnn deleted the snnn/update_absl branch January 24, 2024 22:37
YUNQIUGUO pushed a commit that referenced this pull request Jan 26, 2024
### Description
Update abseil to a release tag and register neural_speed to CG.


### Motivation and Context
Now we are using a non-relesed version of abseil. Using a tag is better.
@snnn
Copy link
Contributor Author

snnn commented Sep 5, 2025

This PR has been cherry-picked into the rel-1.17.0 branch in PR #19243. Removing the release:1.17.0 label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants