Skip to content

[Build] Find openvino based on env variable#19696

Closed
gedoensmax wants to merge 2 commits intomicrosoft:mainfrom
gedoensmax:openvino_cmake_prefix
Closed

[Build] Find openvino based on env variable#19696
gedoensmax wants to merge 2 commits intomicrosoft:mainfrom
gedoensmax:openvino_cmake_prefix

Conversation

@gedoensmax
Copy link
Contributor

I think the change is pretty self explanatory. The openvino installer sets the used Environment variable and therefore finding openvino is easier.

@snnn snnn added the ep:OpenVINO issues related to OpenVINO execution provider label Feb 28, 2024
@jywu-msft
Copy link
Member

are you encountering a case where it can't find openvino?
currently,

if (NOT DEFINED ENV{INTEL_OPENVINO_DIR})
is already checking that openvino is installed and initialized so I had assumed the existing cmake/scripts should all be working?

@gedoensmax
Copy link
Contributor Author

Yes I was encountering the issue without this line. It also tells me I should use find_package(OpenVINO REQUIRED rather than the used finders. I see that this find call is only used for some OV versions, I just pushed a fix that removes some complexity in build scrips. I believe that drops support for older OV's but not sure if that would still be needed.

@jywu-msft
Copy link
Member

Yes I was encountering the issue without this line. It also tells me I should use find_package(OpenVINO REQUIRED rather than the used finders. I see that this find call is only used for some OV versions, I just pushed a fix that removes some complexity in build scrips. I believe that drops support for older OV's but not sure if that would still be needed.

ok thanks. let me loop in OV EP maintainers to review.

@jywu-msft
Copy link
Member

jywu-msft commented Feb 28, 2024

@sfatimar , @preetha-intel , can you take a look at this? seems like @gedoensmax was having issues with the build without making this change. (I believe he's testing on Windows platform)

@jywu-msft
Copy link
Member

/azp run Linux OpenVINO CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@preetha-intel
Copy link
Contributor

@gedoensmax The changes are already part of internal branch that contains changes for OV 2024.0. It will be merged into master around March 15th. Can it happen by then?

@gedoensmax
Copy link
Contributor Author

@preetha-intel Yes sure, thanks for taking care !

@ilya-lavrenov
Copy link
Contributor

Fixed by #19966

@gedoensmax gedoensmax closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ep:OpenVINO issues related to OpenVINO execution provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants