Skip to content

[WebNN EP] Update data type constraints for Reduction ops#20912

Merged
guschmue merged 1 commit intomicrosoft:mainfrom
Honry:reduction-64-bit
Jun 17, 2024
Merged

[WebNN EP] Update data type constraints for Reduction ops#20912
guschmue merged 1 commit intomicrosoft:mainfrom
Honry:reduction-64-bit

Conversation

@Honry
Copy link
Contributor

@Honry Honry commented Jun 4, 2024

WebNN Spec adds missing 64-bit integers support for reduceL1, reduceSum, reduceSumSquare and reduceProduct ops at this PR, which has already been implemented in Chromium. Update corresponding data type constraints in WebNN EP.

Besides, WebNN CPU backend currently doesn't support uint64 and uint32 for these ops.

@Honry
Copy link
Contributor Author

Honry commented Jun 4, 2024

@fdwr, @guschmue, PTAL, thanks!

@guschmue
Copy link
Contributor

guschmue commented Jun 6, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@guschmue
Copy link
Contributor

guschmue commented Jun 6, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@guschmue
Copy link
Contributor

guschmue commented Jun 6, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@guschmue guschmue added the ep:WebNN WebNN execution provider label Jun 6, 2024
@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@Honry
Copy link
Contributor Author

Honry commented Jun 14, 2024

@fdwr, @guschmue, can we land this now?

@guschmue guschmue merged commit bbb6dbf into microsoft:main Jun 17, 2024
gyagp pushed a commit to gyagp/onnxruntime that referenced this pull request Jun 18, 2024
…20912)

WebNN Spec adds missing 64-bit integers support for `reduceL1`,
`reduceSum`, `reduceSumSquare` and `reduceProduct` ops at this
[PR](webmachinelearning/webnn#695), which has
already been implemented in Chromium. Update corresponding data type
constraints in WebNN EP.

Besides, WebNN CPU backend currently doesn't support `uint64` and
`uint32` for these ops.
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ep:WebNN WebNN execution provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants