onnxruntime_perf_test: Add -u option to save optimized model#2227
Merged
onnxruntime_perf_test: Add -u option to save optimized model#2227
Conversation
Contributor
|
If we're going to add this I'd strongly suggest this PR gets added as well: #647 #Resolved |
skottmckay
approved these changes
Oct 22, 2019
yufenglee
approved these changes
Oct 23, 2019
tianleiwu
reviewed
Oct 23, 2019
| "\t-P: Use parallel executor instead of sequential executor.\n" | ||
| "\t-o [optimization level]: Default is 1. Valid values are 0 (disable), 1 (basic), 2 (extended), 99 (all).\n" | ||
| "\t\tPlease see onnxruntime_c_api.h (enum GraphOptimizationLevel) for the full list of all optimization levels. \n" | ||
| "\t-u [optimized_model_path]: Specify the optimized model path for saving.\n" |
Contributor
There was a problem hiding this comment.
This is useful. I hope that shape inference result could be also be output in the graph (maybe in another pull request).
How about change -u to -O? Since Optimized is easy to remember (The drawback is -o is taken). #Pending
Contributor
Author
There was a problem hiding this comment.
I thought -O might be reserved for other more frequent options. This option is relatively infrequent so I picked u to avoid conflictions.
In reply to: 338309668 [](ancestors = 338309668)
Contributor
Author
|
Sure. In reply to: 545113121 [](ancestors = 545113121) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: onnxruntime_perf_test: Add -u option to save optimized model
Motivation and Context