Skip to content

Group build args#24337

Merged
snnn merged 37 commits intomainfrom
snnn/parse_args
Apr 8, 2025
Merged

Group build args#24337
snnn merged 37 commits intomainfrom
snnn/parse_args

Conversation

@snnn
Copy link
Contributor

@snnn snnn commented Apr 8, 2025

  1. Split build.py to two files, because currently the file is over 3000 lines. This PR moves 900 of them to a new file.
  2. Put the build args into groups. It makes more explicit that "--x86", "--arm", "--arm64" and "--arm64ec" args are for Windows only.
  3. Remove the "--use_avx512" and "--gen-api-doc" build args, as they are not referenced anywhere. "--gen-api-doc" was for generating documents for pytorch frontend.
  4. Remove MPI related build flags.
  5. Delete tools/ci_build/github/pai/orttraining-ci.yml
  6. Remove --use_preinstalled_eigen and --eigen_path. Now we have a more unified approach for all ORT's dependencies (not just eigen). See https://onnxruntime.ai/docs/build/dependencies.html for more information.
  7. Windows specific build options won't show up on non-Windows platforms. The same for macOS.
  8. Fixed an issue that the builtin Windows memory leak checker was not correctly enabled by default in Debug build

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Changming Sun added 2 commits April 7, 2025 20:04
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Changming Sun added 2 commits April 7, 2025 20:41
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

@snnn snnn merged commit 4dc0e35 into main Apr 8, 2025
152 of 180 checks passed
@snnn snnn deleted the snnn/parse_args branch April 8, 2025 23:21
zhaoxul-qti pushed a commit to CodeLinaro/onnxruntime that referenced this pull request Apr 17, 2025
1. Split build.py to two files, because currently the file is over 3000
lines. This PR moves 900 of them to a new file.
2. Put the build args into groups. It makes more explicit that "--x86",
"--arm", "--arm64" and "--arm64ec" args are for Windows only.
3. Remove the "--use_avx512" and "--gen-api-doc" build args, as they are
not referenced anywhere. "--gen-api-doc" was for generating documents
for pytorch frontend.
4. Remove MPI related build flags.
5. Delete tools/ci_build/github/pai/orttraining-ci.yml
6. Remove --use_preinstalled_eigen and --eigen_path. Now we have a more
unified approach for all ORT's dependencies (not just eigen). See
https://onnxruntime.ai/docs/build/dependencies.html for more
information.
7. Windows specific build options won't show up on non-Windows
platforms. The same for macOS.
ashrit-ms pushed a commit that referenced this pull request Apr 24, 2025
1. Split build.py to two files, because currently the file is over 3000
lines. This PR moves 900 of them to a new file.
2. Put the build args into groups. It makes more explicit that "--x86",
"--arm", "--arm64" and "--arm64ec" args are for Windows only.
3. Remove the "--use_avx512" and "--gen-api-doc" build args, as they are
not referenced anywhere. "--gen-api-doc" was for generating documents
for pytorch frontend.
4. Remove MPI related build flags.
5. Delete tools/ci_build/github/pai/orttraining-ci.yml
6. Remove --use_preinstalled_eigen and --eigen_path. Now we have a more
unified approach for all ORT's dependencies (not just eigen). See
https://onnxruntime.ai/docs/build/dependencies.html for more
information.
7. Windows specific build options won't show up on non-Windows
platforms. The same for macOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants