Update unknown provider error message with current providers#24352
Merged
RyanUnderhill merged 1 commit intomainfrom Apr 9, 2025
Merged
Update unknown provider error message with current providers#24352RyanUnderhill merged 1 commit intomainfrom
RyanUnderhill merged 1 commit intomainfrom
Conversation
guschmue
approved these changes
Apr 8, 2025
tianleiwu
approved these changes
Apr 9, 2025
RyanUnderhill
added a commit
to microsoft/onnxruntime-genai
that referenced
this pull request
Apr 9, 2025
…onfigEntry directly (#1384) Also simplify our AppendExecutionProvider usage. I removed the unnecessary extra step of copying into an unordered_map then back into a std::vector. This also unifies all AppendExecutionProviders together and is now extensible to future unknown providers. Now for unknown providers, Onnxruntime will report an error with a list of the valid providers. In testing, the list in onnxruntime was found to be incomplete, this PR addresses this: microsoft/onnxruntime#24352
ashrit-ms
pushed a commit
that referenced
this pull request
Apr 24, 2025
### Description WebGPU, VitisAI, and DML are missing from the list. ### Motivation and Context If users misspell a provider name this error should be showing them the full possibilities. Leaving one out will lead to confusion. I noticed it when testing new providers in GenAI that the error message was not up to date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WebGPU, VitisAI, and DML are missing from the list.
Motivation and Context
If users misspell a provider name this error should be showing them the full possibilities. Leaving one out will lead to confusion.
I noticed it when testing new providers in GenAI that the error message was not up to date.