[nodejs] support Node.js binding in multi env#24366
Merged
Conversation
Contributor
Author
|
Nodejs binding implementation need to resolve racing condition. (WIP) |
fs-eire
changed the title
Contributor
Author
|
implementation ready for review. |
5 tasks
Contributor
There was a problem hiding this comment.
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
js/node/src/ort_instance_data.cc:7
- The direct inclusion of <Windows.h> may cause build issues on non-Windows platforms; consider wrapping it within a platform-specific conditional compilation block (e.g., #ifdef _WIN32) to ensure cross-platform compatibility.
#include <Windows.h>
js/node/src/inference_session_wrap.cc:80
- Dereferencing OrtInstanceData::OrtEnv() assumes that the global Ort::Env has been properly initialized; consider adding safeguards or ensuring that this precondition is met in all multi-threaded environments.
this->session_.reset(new Ort::Session(*OrtInstanceData::OrtEnv(),
guschmue
approved these changes
Apr 15, 2025
fs-eire
added a commit
that referenced
this pull request
Apr 16, 2025
### Description Update N-API version to 6. - NAPI v6 is required for `napi_set_instance_data` and `napi_get_instance_data`, as used by #24366 - Adding the "binary" field in package.json for CMake-js to work correctly. (was unintentially removed in #24418) ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
ashrit-ms
pushed a commit
that referenced
this pull request
Apr 24, 2025
### Description Implemented a thread safe OrtInstanceData to support Node.js binding in multi env, and add an E2E test for running in worker. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
ashrit-ms
pushed a commit
that referenced
this pull request
Apr 24, 2025
### Description Update N-API version to 6. - NAPI v6 is required for `napi_set_instance_data` and `napi_get_instance_data`, as used by #24366 - Adding the "binary" field in package.json for CMake-js to work correctly. (was unintentially removed in #24418) ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented a thread safe OrtInstanceData to support Node.js binding in multi env, and add an E2E test for running in worker.
Motivation and Context