Add Resize cubic mode without antialias (scales = [1, ≥1, ≥1, 1])

[yihonglyu]

Description

This PR adds support for the Resize operator in cubic mode without antialiasing (antialias=0). It supports scaling constraints of the form [1, scale_h, scale_w, 1], where scale_h ≥ 1 and scale_w ≥ 1.

Motivation and Context

The ARM64 Conv supports FP16, and we have an NhwcTransformer that transforms FP16 Conv to FP16 NhwcFusedConv. As a result, the subsequent Resize op also uses the NHWC format.

[Copilot]

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

onnxruntime/test/providers/cpu/tensor/resize_op_test.cc:2292

• The PR description notes support only for NHWC layout, yet this test is for NCHW. Please confirm if support for NCHW is intentional and update documentation or tests accordingly.

TEST(ResizeOpTest, NoAntialias_AlignCorners_Cubic_Floor_NCHW) {

onnxruntime/core/providers/cpu/tensor/upsamplebase.h:453

• [nitpick] Consider simplifying or reformatting the error message to improve clarity when unsupported scale configurations are detected.

ORT_RETURN_IF_NOT(is_supported,

onnxruntime/core/providers/cpu/tensor/upsample.cc:1336

• [nitpick] Consider renaming or adding an inline comment for 'upscaling' to clarify that it evaluates as true when at least one scale factor is ≥ 1.0f, as this behavior might be non-intuitive.

const bool upscaling = height_scale >= 1.0f || width_scale >= 1.0f;

[github-actions]

You can commit the suggested changes from lintrunner.

[github-actions]

You can commit the suggested changes from lintrunner.

[Copilot]

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

onnxruntime/core/providers/cpu/tensor/upsamplebase.h:447

• [nitpick] Consider renaming 'outer_scale_inner_scale_one' to a more descriptive name (e.g., 'outer_and_innermost_scale_one') to improve readability.

const bool outer_scale_inner_scale_one = (scales[0] == 1.0f && scales[3] == 1.0f);

onnxruntime/core/providers/cpu/tensor/upsample.cc:1338

• [nitpick] Consider adding a clarifying comment explaining why the anti-alias code path is executed when antialias is false but the scaling factors indicate upscaling; this will help future maintainers understand the design decision.

if (antialias_ || (!antialias_ && upscaling)) {

[Copilot]

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

onnxruntime/test/providers/cpu/tensor/resize_op_test.cc:2292

• For NCHW cubic mode without antialiasing, the expected scales vector should follow the pattern [1, ≥1, ≥1, 1] (with the first and last elements equal to 1). The provided scales {1, 2, 3, 4} violates this constraint since the last element is 4.

TEST(ResizeOpTest, NoAntialias_AlignCorners_Cubic_Floor_NCHW) {

onnxruntime/core/providers/cpu/tensor/upsamplebase.h:453

• [nitpick] Consider improving the formatting of the error message string for clarity; the concatenation of string literals may lead to missing spaces between phrases.

ORT_RETURN_IF_NOT(is_supported,

[Copilot]

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

onnxruntime/core/providers/cpu/tensor/upsamplebase.h:446

• [nitpick] Consider renaming 'outer_scales_one' to 'outermost_scales_one' for increased clarity regarding which dimensions are expected to be 1.

const bool outer_scales_one = (scales[0] == 1.0f && scales[1] == 1.0f);

onnxruntime/core/providers/cpu/tensor/upsamplebase.h:453

• [nitpick] The error message for unsupported scale values is quite verbose; consider reformatting or simplifying it to improve readability.

ORT_RETURN_IF_NOT(is_supported,

onnxruntime/test/providers/cpu/tensor/resize_op_test.cc:2393

• [nitpick] Consider linking this FIXME to an issue tracker item or adding more context so that the kCudaExecutionProvider error can be properly tracked and addressed.

      // FIXME: Fix error on kCudaExecutionProvider

[Copilot]

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

onnxruntime/test/providers/cpu/tensor/resize_op_test.cc:2393

• The FIXME comment indicates an outstanding issue with kCudaExecutionProvider in the NHWC test. Consider adding a dedicated test case and tracking the issue externally to ensure complete coverage once the fix is in place.

      // FIXME: Fix error on kCudaExecutionProvider

onnxruntime/core/providers/cpu/tensor/upsample.cc:1340

• [nitpick] The combined condition for invoking the antialias branch in non-NCHW upscaling scenarios might inadvertently apply antialiasing logic when the antialias flag is false. Please verify that this behavior is intended, and consider separating the conditions if different processing is needed for non-antialias upscaling cases.

if (antialias_ || (!is_nchw && upscaling)) {

[Copilot]

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

onnxruntime/core/providers/cpu/tensor/upsample.cc:1336

• [nitpick] Consider renaming 'upscaling' to 'is_upsampling' to more clearly convey that this flag determines when to follow the NHWC upsampling branch.

const bool upscaling = height_scale >= 1.0f && width_scale >= 1.0f;

onnxruntime/core/providers/cpu/tensor/upsample.cc:1352

• Double-check that reusing the antialiasing logic in the NHWC branch (via NhwcResizeBiCubicAntiAlias) is intended for all upsampling cases when antialias is disabled, ensuring consistency with NCHW behavior.

      } else if (!is_nchw && upscaling) {

[Copilot]

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

onnxruntime/test/providers/cpu/tensor/resize_op_test.cc:2292

• The test for NCHW mode uses scales {1, 2, 3, 4} which does not match the documented pattern [1, scale_h, scale_w, 1] (expected last element to be 1). Please verify whether the test inputs or the scaling check logic in UpsampleBase should be updated for consistency.

TEST(ResizeOpTest, NoAntialias_AlignCorners_Cubic_Floor_NCHW) {