[Native WebGPU] Support shared memory version of ReduceOps#24399
Merged
satyajandhyala merged 10 commits intomainfrom Apr 15, 2025
Merged
[Native WebGPU] Support shared memory version of ReduceOps#24399satyajandhyala merged 10 commits intomainfrom
satyajandhyala merged 10 commits intomainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
guschmue
previously approved these changes
Apr 14, 2025
Contributor
|
ReductionOpTest.ReductionVariationTest has some diff |
fs-eire
previously approved these changes
Apr 14, 2025
Contributor
fs-eire
left a comment
fs-eire
left a comment
There was a problem hiding this comment.
I think table driven is better than the previous virtual function approach (GetOpSpecificCode).
There are slightly overhead but it should be OK considering they are only happening when generating shader.
Contributor
Author
In some cases the table driven is not possible, or at least not as simple as this, in the case of naive because there is some computation involved. |
guschmue
approved these changes
Apr 15, 2025
Contributor
|
there is a ut failing on macos that we should fix |
ashrit-ms
pushed a commit
that referenced
this pull request
Apr 24, 2025
### Description Support shared memory version of ReduceOps ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support shared memory version of ReduceOps
Motivation and Context