Closed
Conversation
The OrtModel clashes with a type in the winml public API leading to issues as the linker gets confused. As winml doesn't need any model editing capabilities the cleanest solution is to make it easy to exclude Model Editor API.
skottmckay
commented
Apr 12, 2025
| return LoadWithLoader(loader, "model_loading_from_saved_proto"); | ||
| } | ||
|
|
||
| common::Status InferenceSession::Load(const OrtModel& model_editor_api_model) { |
Contributor
Author
There was a problem hiding this comment.
This code was moved to make the #ifdef's a bit cleaner. No changes to the code.
assuming that's a reasonable usage so removing assert.
jywu-msft
reviewed
Apr 12, 2025
jywu-msft
approved these changes
Apr 13, 2025
Contributor
Author
|
I think this is a better fix and only requires removing the assert on the ORT side: https://github.com/microsoft/win-onnxruntime/pull/37 |
Contributor
Author
|
This approach resolves the issue instead of avoiding it so this PR shouldn't be needed. #24474 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The OrtModel clashes with a type in the winml public API leading to issues as the linker gets confused.
As winml doesn't need any model editing capabilities the cleanest solution is to make it easy to exclude Model Editor API.
Motivation and Context
Resolve type confusion leading to runtime crash in winml